Update general_troubleshooting.rst #3811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix paths for apache2 mod_rewrite - add missing / at start of paths
Member
|
Works here without the leading |
Member
|
Same here. Closing it? |
|
Did not work here, I also even created a PR with the same content, see above. |
Jakuje
added a commit
to Jakuje/documentation
that referenced
this pull request
Jun 15, 2023
The `.htaccess` rules should not have the starting slash otherwise they will never get matched. When running the mod_rewrite in .htaccess, the path is already sanitized and leading slashes stripped. Document also that this is not the case when the rules are used directly from the main apache2 configuration the leading slash is present always, which led to some edit wars of this documentation in the past as it was not well explained (nextcloud#8093, nextcloud#3811). This matches the code shipped with the .htaccess in the nextcloud server: https://github.com/nextcloud/server/blob/master/.htaccess Signed-off-by: Jakub Jelen <jakuje@gmail.com>
Jakuje
added a commit
to Jakuje/documentation
that referenced
this pull request
Jun 15, 2023
The `.htaccess` rules should not have the starting slash otherwise they will never get matched. When running the mod_rewrite in .htaccess, the path is already sanitized and leading slashes stripped. Document also that this is not the case when the rules are used directly from the main apache2 configuration the leading slash is present always, which led to some edit wars of this documentation in the past as it was not well explained (nextcloud#8093, nextcloud#3811). This matches the code shipped with the .htaccess in the nextcloud server: https://github.com/nextcloud/server/blob/master/.htaccess Signed-off-by: Jakub Jelen <jakuje@gmail.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
The `.htaccess` rules should not have the starting slash otherwise they will never get matched. When running the mod_rewrite in .htaccess, the path is already sanitized and leading slashes stripped. Document also that this is not the case when the rules are used directly from the main apache2 configuration the leading slash is present always, which led to some edit wars of this documentation in the past as it was not well explained (#8093, #3811). This matches the code shipped with the .htaccess in the nextcloud server: https://github.com/nextcloud/server/blob/master/.htaccess Signed-off-by: Jakub Jelen <jakuje@gmail.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
The `.htaccess` rules should not have the starting slash otherwise they will never get matched. When running the mod_rewrite in .htaccess, the path is already sanitized and leading slashes stripped. Document also that this is not the case when the rules are used directly from the main apache2 configuration the leading slash is present always, which led to some edit wars of this documentation in the past as it was not well explained (#8093, #3811). This matches the code shipped with the .htaccess in the nextcloud server: https://github.com/nextcloud/server/blob/master/.htaccess Signed-off-by: Jakub Jelen <jakuje@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix paths for apache2 mod_rewrite - add missing / at start of paths