nginx: fix autoloading for some builtins apps#5284
Closed
Mic92 wants to merge 1 commit intonextcloud:masterfrom
Closed
nginx: fix autoloading for some builtins apps#5284Mic92 wants to merge 1 commit intonextcloud:masterfrom
Mic92 wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
10 tasks
Member
|
cc @josh4trunks |
MorrisJobke
reviewed
Oct 25, 2020
|
|
||
| location / { | ||
| try_files $uri $uri/ /index.php$request_uri; | ||
| try_files $uri/ /index.php$request_uri; |
Member
There was a problem hiding this comment.
Suggested change
| try_files $uri/ /index.php$request_uri; | |
| try_files $uri/ /index.php$request_uri; |
Contributor
|
I think the full fix is explained here. Does anyone mind making this a PR so we can review/test? |
Contributor
Author
|
OK. Maybe original PR should be revoked completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 6b40a23#diff-e6fc0cd0bc2157559d74ab9196ea4209f9205a94865839d0f7b32b9810365c78
the way nginx access files was changed. This broke some apps like user_ldap, where ajax function are called from the directory directly. They need to be executed through the top-level index.php, or otherwise they will find their dependencies. Maybe this should be reverted back to
rewrite ^ /index.php;? cc @jivanpal