Update app to latest document server

[aaronhuggins]

• Bumps document server to version 7.2.1
• Bumps supported Nextcloud to version 25
• Fixes segfaults in both local dev and most app environments
• Improves make clean
• Docker is now compiled differently from generic linux builds; this change pulls in document server by extracting from rpm instead of Docker

Signed-off-by: Aaron Huggins aaron.huggins@runbox.com

[aaronhuggins]

For interested people looking to try out this upgrade before release:
https://github.com/aaronhuggins/documentserver_community/releases/tag/v0.1.13

Publishing as a patch for interested early adopters and risk takers only.

USE AT YOUR OWN RISK UNTIL OFFICIAL RELEASE IS SIGNED OFF ON.

Implements OnlyOffice Document Server 7.2.1. Confirmed in a limited way to work with Nextcloud 24 and 25. Upgrading the plugin appears to work correctly as well.

If you see a message telling you "The editor version has been updated. The page will be reloaded to apply the changes.", you must log out of Nextcloud, clear your browser cache, and log back in.

Screenshot of "update" message:

[mtnbiker777]

For interested people looking to try out this upgrade before release: https://github.com/aaronhuggins/documentserver_community/releases/tag/v0.1.13

Publishing as a patch for interested early adopters and risk takers only.
USE AT YOUR OWN RISK UNTIL OFFICIAL RELEASE IS SIGNED OFF ON.
Implements OnlyOffice Document Server 7.2.1. Confirmed in a limited way to work with Nextcloud 24 and 25. Upgrading the plugin appears to work correctly as well.
If you see a message telling you "The editor version has been updated. The page will be reloaded to apply the changes.", you must log out of Nextcloud, clear your browser cache, and log back in.
Screenshot of "update" message:

Is there an official release eventually coming that supports 24/25?

[aaronhuggins]

@mtnbiker777 I don't know. I've tried to write this PR to be that support for NC 24/25 (because I need it for my family).

I'll try to make noise on the forums, but I think the only way to get this moving is to reach out to actual Nextcloud org members.

As a bonus, I've already experimented and I think my changes here can be expanded to include support for Arm platforms, too. But that's another PR, another day. So I think my preliminary fixes in this PR have some legs.

@nextcloud-bot @icewind1991 @hershelsr @ChristophWurst Who do we contact to get PRs reviewed, merged, and released to the Apps marketplace for this repository?

[aaronhuggins]

@mtnbiker777 I've opened a topic on the forums.

https://help.nextcloud.com/t/pull-request-for-onlyoffice-document-server-community-app/148934

[aaronhuggins]

@mrbaseman If you have any issues crop up while trying it out on your hosted install, let me know here.

[mrbaseman]

One difference that I notice: I believe I could edit Office documents from my Android phone. But if I try to do so, I get a warning now, that a commercial license would be needed

[mrbaseman]

From the laptop I could upload and edit a text document, create and edit a table, open documents which were created or uploaded before the update. (Note that also the onlyoffice app and the nextcloud installation were upgraded)

[aaronhuggins]

@mrbaseman I've had that message for mobile document editing since 2018. Not sure how anyone would have worked around that since that time. I believe that's just a behavior of the free OnlyOffice Document Server.

[mrbaseman]

I can remember a limitation to 20 concurrent sessions in the community edition, no matter which device type. But well, obviously they have changed this at some point in the past...

[mcmilk]

I installed nextcloud on Ubuntu 22.04 ... so the default binary of allfontsgen (document server 0.1.12) will not work.

[root@nextcloud ../3rdparty/onlyoffice/documentserver/server/tools/old]# ldd allfontsgen 
        linux-vdso.so.1 (0x00007ffeda6d1000)
        libgraphics.so => not found
        libkernel.so => not found
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f30ff929000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f30ff924000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f30ff6fc000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f30ff953000)

Your version of allfontsgen looks via ldd okay ... but it throws an error:

[11826685.245173] allfontsgen[890906]: segfault at 8 ip 00007fb86261c4e0 sp 00007ffcd0603ee0 error 4 in libUnicodeConverter.so[7fb862600000+37000]

It would be nice, if this binary could be provided statically linked ...
Could you give me some hints, how I can do this by hand?

[aaronhuggins]

@mcmilk I'll have a look this weekend.

EDIT: Was not able to reproduce, but given that there were some binary differences with the Ubuntu-based docker container I think there's an issue. Will look further next weekend.

[aaronhuggins]

@mcmilk I installed a fresh Ubuntu 22.04 server VM and stepped through the entire build process. I was unable to reproduce your error.

If you can provide more details about the steps you took, I might be able to see if there's something different and try to reproduce again.

[icewind1991]

Many thanks for the work and apologies for not seeing the PR earlier.

[aaronhuggins]

@icewind1991 Thank you so much. I'm hoping to submit some more PRs in the next month or so, including a change that would build arm64 for RPi support. Would you like me to open a separate issue to discuss methodology on that? Or just submit a PR with my preferred solution for building arm64?

EDIT: If I don't hear back before Nov 23-25, I'll just open a PR for arm64 support as I hope to have time to experiment with Raspberry Pi that weekend.

[icewind1991]

Sending a PR is fine, I'll try to at keep a better eye at them

[mcmilk]

@mcmilk I installed a fresh Ubuntu 22.04 server VM and stepped through the entire build process. I was unable to reproduce your error.
If you can provide more details about the steps you took, I might be able to see if there's something different and try to reproduce again.

I am using docker for the document server now ... this runs fine.
I will re-try with ubuntu 22.04 when I have some time for it.... thank you a lot, for testing, and also for your work on this project.

[reysonk]

In version 0.1.13, unlike 0.1.12, the mobile editing functionality refers to the purchase of a license.
In version 0.1.12 this functionality is available

[aaronhuggins]

@reysonk Mobile editors have always required a license for the community edition, which is bundled in this app. If the editors for mobile were working, your server admin may have previously implemented a workaround (which I will not link).

You can refer to the feature matrix here.

• Latest: https://github.com/ONLYOFFICE/DocumentServer#onlyoffice-document-server-editions
• v6.4.2 (which was bundled in app v0.1.12): https://github.com/ONLYOFFICE/DocumentServer/tree/v6.4.2#onlyoffice-document-server-editions

[reysonk]

@reysonk Mobile editors have always required a license for the community edition, which is bundled in this app. If the editors for mobile were working, your server admin may have previously implemented a workaround (which I will not link).

You can refer to the feature matrix here.

• Latest: https://github.com/ONLYOFFICE/DocumentServer#onlyoffice-document-server-editions
• v6.4.2 (which was bundled in app v0.1.12): https://github.com/ONLYOFFICE/DocumentServer/tree/v6.4.2#onlyoffice-document-server-editions

#276 (comment)