Fix PDF sidebar shown in PDF thumbnails #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF viewer remembers whether the PDF sidebar was open or closed for each PDF file the last time it was viewed. Thus, when the PDF file is rendered in a thumbnail the sidebar must be explicitly hidden to ensure that it will never be shown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Nov 26, 2018
|
/backport to stable15 |
|
backport to stable15 in #114 |
|
/backport to stable14 |
|
/backport to stable13 |
|
backport to stable14 in #115 |
|
backport to stable13 in #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
The PDF viewer remembers whether the PDF sidebar was open or closed for each PDF file the last time it was viewed. Thus, when the PDF file is rendered in a thumbnail the sidebar must be explicitly hidden to ensure that it will never be shown.
I miss a Nextcloud 16 milestone to set :-)