[stable33] Allow PDF Forms calculations#1409
Merged
Conversation
@nextcloud/vue was already an implicit dependency, but version 9.x was used, which is compatible only with Vue 3. As the PDF viewer uses Vue 2 the explicit dependency needs to be set to version 8.x instead, as otherwise its components would not work (but this does not affect the use of version 9.x by the dependencies themselves). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This PR adds a UI to configure the pdf viewer to allow calculations (secure in a sandbox). Can be enabled/disabled through the admin settings globally, default is disabled. Uses pdf.js´s sandbox feature, which should make this as secure as it can get. Fixes #1265 Signed-off-by: Joly0 <13993216+Joly0@users.noreply.github.com>
8ffb90d to
771279a
Compare
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
dd98acf to
68270fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1325