Allow downloads in sandboxed iframe #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now it was possible to initiate a download from an iframe, but the HTML spec has been updated to prevent that unless "allow-downloads" is set in the "sandbox" attribute of the iframe. As the PDF viewer shows the PDF file in an iframe the "allow-downloads" attribute is needed to be able to download the PDF file by clicking on the "Download" button of the UI in browsers that have implemented the spec change (like Chromium 83; other browsers are expected to follow). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
ChristophWurst
approved these changes
Jun 4, 2020
This was referenced Jun 4, 2020
t-oster
added a commit
to t-oster/files_pdfviewer
that referenced
this pull request
Aug 11, 2020
In chrome 83 an iframe is not allowed to initiate a download except when the sandbox=allow-downloads attribute is set. Same as nextcloud/files_pdfviewer#186
SamuAlfageme
pushed a commit
to SamuAlfageme/files_pdfviewer
that referenced
this pull request
Apr 15, 2021
In chrome 83 an iframe is not allowed to initiate a download except when the sandbox=allow-downloads attribute is set. Same as nextcloud/files_pdfviewer#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now it was possible to initiate a download from an iframe, but the HTML spec has been updated to prevent that unless "allow-downloads" is set in the "sandbox" attribute of the iframe.
As the PDF viewer shows the PDF file in an iframe the "allow-downloads" attribute is needed to be able to download the PDF file by clicking on the "Download" button of the UI in browsers that have implemented the spec change (like Chromium 83; other browsers are expected to follow).