Skip to content

Add F-Droid #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Aug 23, 2021
Merged

Add F-Droid #566

juliusknorr merged 1 commit into from
Aug 23, 2021

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 16, 2021

Fix part of nextcloud/server#25905
Requires nextcloud/server#26481
0
1

Replacing #511

@juliusknorr juliusknorr mentioned this pull request Jul 16, 2021
Closed
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Jul 16, 2021
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 19, 2021 •
edited
Loading

  • Fix tests
1) OCA\FirstRunWizard\Tests\Controller\WizardControllerTest::testShowUser
OCP\IConfig::getSystemValue('customclient_ios', 'geo.itunes.apple.com/...2?mt=8') was not expected to be called more than 4 times.

/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/lib/Controller/WizardController.php:89
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:109

2) OCA\FirstRunWizard\Tests\Controller\WizardControllerTest::testShowAdmin with data set "app store enabled" (true, 4)
OCP\IConfig::getSystemValue('customclient_ios', 'geo.itunes.apple.com/...2?mt=8') was not expected to be called more than 4 times.

/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/lib/Controller/WizardController.php:89
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:146

3) OCA\FirstRunWizard\Tests\Controller\WizardControllerTest::testShowAdmin with data set "app store disabled" (false, 3)
OCP\IConfig::getSystemValue('customclient_ios', 'geo.itunes.apple.com/...2?mt=8') was not expected to be called more than 4 times.

/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/lib/Controller/WizardController.php:89
/home/runner/work/firstrunwizard/firstrunwizard/apps/firstrunwizard/tests/Controller/WizardControllerTest.php:146

FAILURES!

jancborchardt
jancborchardt approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks good design-wise. :)

@juliusknorr
Add F-Droid
e22fc68 
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 356dc3a into master Aug 23, 2021
@juliusknorr juliusknorr deleted the enh/fdroid branch August 23, 2021 12:32
@joshtrichards joshtrichards mentioned this pull request Jul 8, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @jancborchardt @szaimen