Database error when running migration 050000Date20241005173955

[tobiasKaminsky]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. upgrade our daily instance
2. see error

Expected behaviour

migration should work

Actual behaviour

$ ./occ app:enable forms
Database error when running migration 050000Date20241005173955 for app forms
An exception occurred while executing a query: SQLSTATE[42703]: Undefined column: 7 ERROR:  column "3" does not exist
LINE 1: ..."access_enum" = "access_enum - 3" WHERE "access_enum" >= "3"

Server configuration

daily LTD server with PostGres DB
If you need more info, please ping me on chat

[susnux]

This logic does not work:

forms/lib/Migration/Version050000Date20241005173955.php

Line 34 in 7956a17

->set('access_enum', 'access_enum - 3')

I think we need to use a function here instead of simple set. Otherwise the whole thing gets quoted = expected to be a column

[Chartman123]

Is this dependent on the database? I tested it locally and it worked fine with MariaDB IIRC

[susnux]

Is this dependent on the database? I tested it locally and it worked fine with MariaDB IIRC

No it will always be quoted, maybe you did not have a value of 3+? Or there is a bug in doctrine^^
We should use instead this:

https://github.com/nextcloud/server/blob/dae7c159f728a90ffa53247d6e033abdae5d2bd6/lib/public/DB/QueryBuilder/IFunctionBuilder.php#L96

[nickvergessen]

Working sample:

		$query->set('permissions', $query->func()->add(
			'permissions',
			$query->createNamedParameter($permission, IQueryBuilder::PARAM_INT)
		));

I guess you would need to use subtract()

[Chartman123]

Yes I had one before the test running... and no error. Really strange. @susnux do you want to create the fix or should I?

[tobiasKaminsky]

Thank you for this quick fix.
It works with postgres 👍