Sidebar toggle not shown when you start in results view

[Chartman123]

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
If you start to view a form in the results view, the sidebar toggle button isn't shown.

Expected behavior
Toggle should always be shown when you have the permission to edit the forms settings/sharing

Nextcloud (please complete the following information):

• Forms-Version: all versions since 4.3.0

[Chartman123]

@susnux any idea why this happens and why it's working at all in both other views?

forms/src/components/TopBar.vue

Line 31 in 8d80f42

v-if="showSidebarToggle"

I mean we're never setting showSidebarToggle anywhere so it should always be undefined and thus false, shouldn't it?

Edit:

Ok, seems like we're not using that button at all but the built-in toggle button of the NcAppSidebar component. I'll remove the button.

Edit 2:

The button re-appeared in our code, probably during some fixing of merge conflicts when we switched the code styling to prettier. However this has no influence on the missing sidebar toggle in the results view.

[susnux]

The sidebar toggle is part of the sidebar nowadays, I think we can remove that button at all from the TopBar.