Conversation
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
added
3. to review
susnux
approved these changes
Apr 16, 2025
Collaborator
Author
|
/backport to stable5 |
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some Vue warnings in the browser console. One was about a missing required prop
disabledfor the PIllMenu. I changed the prop to have a default value offalse.The other two changes are related to a11y and missing ariaLabelComboboxes for NcSelect components in the sharing sidebar and the dropdown question type.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de