Skip to content

fix(export): escape CSV export for spreadsheet applications#2804

Merged
Chartman123 merged 1 commit intomainfrom
fix/escape-csv
Jul 3, 2025
Merged

fix(export): escape CSV export for spreadsheet applications#2804
Chartman123 merged 1 commit intomainfrom
fix/escape-csv

Conversation

@susnux
Copy link
Copy Markdown
Collaborator

@susnux susnux commented Jul 3, 2025

While in theory CSV is just plain data most users do not care and open it anyways in applications like Excel or LibreOffice. This can cause unwanted behavior if the cell value is evaluated like a formula.
So for this we manually escape suche values.

While in theory CSV is just plain data most users do not care and open
it anyways in applications like Excel or LibreOffice.
This can cause unwanted behavior if the cell value is evaluated like a
formula.
So for this we manually escape suche values.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 5.2 milestone Jul 3, 2025
@susnux susnux requested a review from Chartman123 July 3, 2025 12:59
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jul 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (7752929) to head (b8d0410).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2804      +/-   ##
============================================
+ Coverage     45.53%   45.67%   +0.14%     
- Complexity      990      993       +3     
============================================
  Files            79       79              
  Lines          3591     3599       +8     
============================================
+ Hits           1635     1644       +9     
+ Misses         1956     1955       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123 Chartman123 merged commit 4cc60f4 into main Jul 3, 2025
63 of 70 checks passed
@Chartman123 Chartman123 deleted the fix/escape-csv branch July 3, 2025 22:02
@susnux
Copy link
Copy Markdown
Collaborator Author

susnux commented Jul 7, 2025

/backport to stable5

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jul 7, 2025
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants