Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Nov 20, 2025

Fixed two issues:

1. Selecting a result had no effect

Screencast.From.2025-11-20.16-19-37.mp4

2. Non-user results were presented to the user

Fix #3049

Before After
image image

Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge artonge self-assigned this Nov 20, 2025
@artonge artonge added bug Something isn't working javascript Javascript related ticket feature: 👥 sharing settings 3. to review Waiting for reviews labels Nov 20, 2025
@artonge artonge force-pushed the artonge/fix/sharing branch from 77fb729 to c5715a0 Compare November 20, 2025 15:21
@artonge artonge requested review from hamza221 and susnux November 20, 2025 15:26
@artonge artonge force-pushed the artonge/fix/sharing branch from c5715a0 to e2aac67 Compare November 20, 2025 15:34
@artonge artonge force-pushed the artonge/fix/sharing branch from e2aac67 to 84ab135 Compare November 20, 2025 16:02
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks sharing with groups or teams.

That is not what #3049 is about.
#3049 is about the ownership transfer not the sharing. Sharing still needs to be possible with groups and teams.

@artonge artonge force-pushed the artonge/fix/sharing branch from 84ab135 to eb41bd9 Compare November 20, 2025 18:07
@artonge
Copy link
Contributor Author

artonge commented Nov 20, 2025

#3049 is about the ownership transfer not the sharing. Sharing still needs to be possible with groups and teams.

Oups, indeed, shouldn't have rushed it...

Corrected.

@artonge artonge force-pushed the artonge/fix/sharing branch from eb41bd9 to 5d82c3a Compare November 20, 2025 18:14
@artonge artonge changed the title fix(Sharing): Only list users in select input fix(Settings): Only list users in transfer ownership Nov 20, 2025
@artonge artonge force-pushed the artonge/fix/sharing branch from 5d82c3a to 8eb1c5f Compare November 20, 2025 18:50
@Chartman123
Copy link
Collaborator

@artonge @susnux I've also already looked at this bug and tried to fix it with the filter-by prop of NcSelectUser but wasn't successful. There might be a bug in the vue lib that prevents passing the filter function to the component. But this filter would probably be the easiest way to fix this.

@artonge
Copy link
Contributor Author

artonge commented Nov 21, 2025

But this filter would probably be the easiest way to fix this.

Yeah, that or a computed property.

The advantage of the current solution is that we do not ask the server for more information than we need. Happy to comply, thought :).

@Chartman123
Copy link
Collaborator

Chartman123 commented Nov 21, 2025

Yes, that was also my first attempt to fix it, but I didn't succeed in passing the required parameters to the search mixin. Which we should also get rid of during vue3 migration.

@artonge artonge force-pushed the artonge/fix/sharing branch 2 times, most recently from 101562c to 0b99ffe Compare November 21, 2025 09:21
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/sharing branch from 0b99ffe to 0436c4e Compare November 21, 2025 09:23
@Chartman123 Chartman123 requested a review from susnux November 21, 2025 09:28
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it on my local instance, works as expected. @artonge thank you very much!

Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@susnux
Copy link
Collaborator

susnux commented Nov 21, 2025

/backport to stable5.2

@Chartman123 Chartman123 merged commit 255662c into main Nov 21, 2025
44 checks passed
@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 21, 2025
@Chartman123 Chartman123 deleted the artonge/fix/sharing branch November 21, 2025 10:04
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Nov 21, 2025
@artonge
Copy link
Contributor Author

artonge commented Dec 2, 2025

/backport to stable4

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Dec 2, 2025
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only show users in transfer dialog

4 participants