-
Notifications
You must be signed in to change notification settings - Fork 112
fix(Settings): Only list users in transfer ownership #3050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Louis Chmn <louis@chmn.me>
77fb729 to
c5715a0
Compare
c5715a0 to
e2aac67
Compare
e2aac67 to
84ab135
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
84ab135 to
eb41bd9
Compare
Oups, indeed, shouldn't have rushed it... Corrected. |
eb41bd9 to
5d82c3a
Compare
5d82c3a to
8eb1c5f
Compare
Yeah, that or a computed property. The advantage of the current solution is that we do not ask the server for more information than we need. Happy to comply, thought :). |
|
Yes, that was also my first attempt to fix it, but I didn't succeed in passing the required parameters to the search mixin. Which we should also get rid of during vue3 migration. |
101562c to
0b99ffe
Compare
Signed-off-by: Louis Chmn <louis@chmn.me>
0b99ffe to
0436c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it on my local instance, works as expected. @artonge thank you very much!
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
/backport to stable5.2 |
|
/backport to stable4 |
Fixed two issues:
1. Selecting a result had no effect
Screencast.From.2025-11-20.16-19-37.mp4
2. Non-user results were presented to the user
Fix #3049