fix(activity): throw UnknownActivityException for unknown events#3344
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
added
3. to review
Chartman123
approved these changes
May 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
provokateurin
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Activity manager loops over every registered provider and expects each one to throw if the event isn't theirs. We were doing that with
\InvalidArgumentException, which has been deprecated for this purpose since NC 30. Swapped to\OCP\Activity\Exceptions\UnknownActivityExceptionso "not my event" is distinguishable from a real parser bug.see: nextcloud/server#59609