This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Hide the share drop down when closing the slideshow #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The share drop down is shared between the gallery and the slideshow. When the share button of the gallery is clicked the share drop down is shown only if it is not already being shown. However, if the slideshow is closed while the drop down is being shown the gallery considers that the drop down is being shown (even if it is not visible to the user), so clicking on the share button does nothing in that case. Now the drop down is explicitly hidden when the slideshow is closed to ensure that the share button of the gallery works as expected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
MorrisJobke
deleted the
hide-the-share-drop-down-when-closing-the-slideshow
branch
Member
|
Backported and tested: stable13 714a6a2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The share drop down is shared between the gallery and the slideshow. When the share button of the gallery is clicked the share drop down is shown only if it is not already being shown. However, if the slideshow is closed while the drop down is being shown the gallery considers that the drop down is being shown (even if it is not visible to the user), so clicking on the share button does nothing in that case. Now the drop down is explicitly hidden when the slideshow is closed to ensure that the share button of the gallery works as expected.
Note that the problem was really minor because only the first click after closing the slideshow failed. As that click was not done on the drop down the drop down was closed, so the next time that the button was clicked the drop down was shown as expected.