Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Conversation

@danxuliu
Copy link
Member

@danxuliu danxuliu commented Jan 8, 2018

The share button is now an input element like the rest of the slideshow buttons.

Besides getting a cleaner code it fixes the share button not being hidden like the rest of the slideshow buttons when the pointer was not moved for three seconds.

This pull request also cleans some related code and adds a tooltip for the Share button.

In the stable12 branch the Share button was hidden, but there was a small glitch: while the rest of the buttons fade from their current opacity (0.5) the Share button first changed to an opacity of 1 and then faded, which made the Share button look like it was highlighted.

If this is worth a backport tell me ;-)

@nextcloud/designers

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The share button is now an input element like the rest of the slideshow
buttons.

Besides getting a cleaner code it fixes the share button not being
hidden like the rest of the slideshow buttons when the pointer was not
moved for three seconds.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added bug Something isn't working design Related to the design feature:slideshow labels Jan 8, 2018
@MorrisJobke MorrisJobke requested review from oparoz and skjnldsv January 8, 2018 07:39
@jancborchardt
Copy link
Member

Could we also use this opportunity to move the share button to the right of the file name? :) And the other actions for Download and Delete should be behind a 3-dot-menu right next to the share icon then, so it's the same as in Files.

The slideshow button can move to the top instead.

What do you think @danxuliu?

@jancborchardt
Copy link
Member

(Actually just found #276 again. ;) I updated that one, better to go ahead like that.)

@danxuliu
Copy link
Member Author

@jancborchardt Nextcloud 13 is around the corner, and this pull request fixes a bug, so in my opinion it should be merged before improving the layout, which may not be finished in time (it will depend on how much time others have, because unfortunately I do not have any for it ;-) ).

@jancborchardt
Copy link
Member

@danxuliu sure, 👍 then :)

@rullzer rullzer added this to the Nextcloud 14 milestone Jan 20, 2018
@rullzer
Copy link
Member

rullzer commented Jan 20, 2018

CI failure needs to be fixed but unrelated here.

@danxuliu if you think this has to be in 13 please open a backport. But I would vote to get it into 13.0.1 then.

@rullzer rullzer merged commit 8776be9 into master Jan 20, 2018
@rullzer rullzer deleted the unify-slideshow-share-button-with-the-rest-of-slideshow-buttons branch January 20, 2018 09:18
@danxuliu
Copy link
Member Author

danxuliu commented Jan 22, 2018

if you think this has to be in 13 please open a backport.

Done: #368

But I would vote to get it into 13.0.1 then.

I have added it to the Nextcloud 13 milestone, but it would be fine in 13.0.1.

In any case, my question about the backport was more related to the glitch in Nextcloud 12 ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants