fix(versions): Check the class of the file's storage instead of the mountpoint#4309
Merged
fix(versions): Check the class of the file's storage instead of the mountpoint#4309
Conversation
artonge
added
bug
3. to review
artonge
force-pushed
the
artonge/fix/version_storage_check
branch
2 times, most recently
from
ae8c585 to
569e22e
Compare
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
artonge
force-pushed
the
artonge/fix/version_storage_check
branch
from
569e22e to
090b0e5
Compare
…ountpoint 1. Create a groupfolder 2. Create a file inside that groupfolder 3. Share the file to Alice 4. As Alice, list the file version --> fails If we check the mount point, we are not really checking the actual storage of the file. Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/version_storage_check
branch
from
090b0e5 to
aacab2d
Compare
provokateurin
approved these changes
Jan 28, 2026
This was referenced Jan 28, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we check the mount point, we are not really checking the actual storage of the file.