fix(ACL): apply ACL rules in the correct order#4429
Merged
CarlSchwan merged 1 commit intomasterfrom Feb 19, 2026
Merged
Conversation
provokateurin
requested changes
Feb 19, 2026
a6a8a75 to
b61d15c
Compare
provokateurin
approved these changes
Feb 19, 2026
Before this change the filteredRules array would be flipped in comparison to the $rules. So rules for the parents would be applied before rules for the children. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>
b61d15c to
19e4ee4
Compare
salmart-dev
approved these changes
Feb 19, 2026
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/4429/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19e4ee42
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4429/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/4429/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19e4ee42
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4429/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the filteredRules array would be flipped in comparison to the $rules. So rules for the parents would be applied before rules for the children.