Skip to content

fix(ACL): apply ACL rules in the correct order#4429

Merged
CarlSchwan merged 1 commit intomasterfrom
fix/rule-apply-order
Feb 19, 2026
Merged

fix(ACL): apply ACL rules in the correct order#4429
CarlSchwan merged 1 commit intomasterfrom
fix/rule-apply-order

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

Before this change the filteredRules array would be flipped in comparison to the $rules. So rules for the parents would be applied before rules for the children.

@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Feb 19, 2026
@CarlSchwan CarlSchwan self-assigned this Feb 19, 2026
@CarlSchwan CarlSchwan added the 3. to review Items that need to be reviewed label Feb 19, 2026
Comment thread lib/ACL/ACLManager.php Outdated
Before this change the filteredRules array would be flipped in
comparison to the $rules. So rules for the parents would be applied
before rules for the children.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan enabled auto-merge February 19, 2026 12:23
@CarlSchwan CarlSchwan merged commit 4ccec7f into master Feb 19, 2026
58 of 64 checks passed
@CarlSchwan CarlSchwan deleted the fix/rule-apply-order branch February 19, 2026 14:07
@provokateurin
Copy link
Copy Markdown
Member

/backport to stable33

@provokateurin
Copy link
Copy Markdown
Member

/backport to stable32

@provokateurin
Copy link
Copy Markdown
Member

/backport to stable31

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Feb 19, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/4429/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19e4ee42

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4429/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented Feb 19, 2026

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/4429/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19e4ee42

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4429/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants