[stable32] fix(api): cleanly reject duplicate group assignment#4672
Merged
Conversation
When the same group is POSTed twice to /folders/{id}/groups, the second
request hit a UNIQUE-constraint violation deep inside addApplicableGroup
and surfaced as an HTML 500 page that crashed XML clients (#2180).
Pre-check the folder's existing groups (already loaded by
checkedGetFolder) and throw OCSBadRequestException with a clear message
when the group is already assigned. The existing OCS framework turns
that into a well-formed XML/JSON error response, matching the pattern
the controller already uses for duplicate mount points (line 229) and
duplicate folder names elsewhere in the file.
Closes #2180
Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #4668