Skip to content

fix: Handle failure when creating user #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 1 commit into from
Mar 5, 2026
Merged

fix: Handle failure when creating user #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/BackgroundJob/TransferJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,16 @@ public function run($argument): void {
return;
}

$targetUser = $this->userManager->createUser(
$target,
$this->secureRandom->generate(20), // Password hash will be copied to target user from source user
);
try {
$targetUser = $this->userManager->createUser(
$target,
$this->secureRandom->generate(20), // Password hash will be copied to target user from source user
);
} catch (\Exception) {
$this->logger->error('Cannot transfer guest user "' . $source . '", target user "' . $target . '" creation failed');
$this->fail($transfer);
return;
}

if (!$targetUser instanceof IUser) {
$this->logger->error('Failed to create new user: ' . $target);
Expand Down
Loading