fix(invite): send welcome email when creating guest from share dialog#1566
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
CarlSchwan
approved these changes
May 13, 2026
Altahrim
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GuestFormsendssendInvite: falsewhen opened from the Files share dialog. Intent (cc @leftybournes, this was set up in 0c42d5c) was to dedupe withShareCreatedListener, which sends its own "X shared a file with you" mail after the share lands. Problem: the share only lands when the user clicks confirm on theSharingDetailsTabthat opens after the guest form closes. If they close the sidebar or navigate away, the guest exists with no welcome mail and no password-reset link, so they can't log in at all.Dropping the flag entirely. Backend defaults to
sendInvite: true, so the welcome fires at creation regardless of integration. If a share follows, the listener still sends the contextualised share mail on top.Both mails carry the same
lostpasswordtoken URL, so the duplicate Activate-account buttons land on the same setup flow. Net cost: two mails in the happy path. Net benefit: no more stranded guest accounts.@leftybournes - flagging in case I'm missing context on the original dedup decision. The two mails are textually different so this isn't a literal duplicate, but happy to revisit if there was a UX concern I'm not seeing.
Backport
stable4.7, stable4.6, stable4.5