Skip to content

Update mariadb#152

Merged
tvories merged 3 commits intonextcloud:masterfrom
greenhost:update-mariadb
Oct 21, 2021
Merged

Update mariadb#152
tvories merged 3 commits intonextcloud:masterfrom
greenhost:update-mariadb

Conversation

@ariep
Copy link
Copy Markdown
Contributor

@ariep ariep commented Oct 7, 2021

Pull Request

Description of the change

Update mariadb dependency chart to most recent version.

Benefits

Enjoy all benefits of new and improved mariadb, both the program itself as well as helm packaging.

Our primary motivation for doing this was that the newer chart version allows setting custom kubernetes labels on the mariadb statefulset and its pods, which is something we need for our backup/restore solution that uses velero.

Possible drawbacks

  1. The mariadb chart has made some incompatible changes, see their upgrade notes. Depending on a user's setup (replicated or standalone) this may require manual intervention when upgrading.
  2. Because the mariadb chart has started using the bitnami "common library chart", it became harder to recreate the database's kubernetes service name, which is calculated by a helm template function. Nextcloud needs to know this service name because it uses that as hostname to contact the database service. Luckily there is an elegant principled solution in helm, to allow calling a subchart's template functions, instead of having to copy their definition. The downside is that solution is only supported by a very recent helm version (3.7.0, released three weeks ago), so this would put rather strict helm version requirements on anyone using this helm chart.

There is no upgrade guide in the README currently, but 1. should really be documented somewhere.

If deemed necessary, maybe we could mitigate 2. by checking for the presence of .Subcharts, and defaulting to the old template function to compute the database service name.

Applicable issues

Checklist

ariep added 3 commits October 7, 2021 16:16
Signed-off-by: Arie Peterson <arie@greenhost.nl>
Signed-off-by: Arie Peterson <arie@greenhost.nl>
Signed-off-by: Arie Peterson <arie@greenhost.nl>
@varac
Copy link
Copy Markdown
Contributor

varac commented Oct 21, 2021

@tvories Any chance to get this reviewed soon ?

@tvories tvories marked this pull request as ready for review October 21, 2021 17:08
@tvories tvories merged commit 6c158b9 into nextcloud:master Oct 21, 2021
@varac
Copy link
Copy Markdown
Contributor

varac commented Oct 21, 2021

@tvories Awesome, thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants