Support for extra sidecars#309
Merged
tvories merged 1 commit intonextcloud:masterfrom Nov 3, 2022
Merged
Conversation
mikaelh
force-pushed
the
feat/sidecars
branch
from
846be80 to
b8f6541
Compare
Contributor
Author
|
bumped version number 3.2.3 |
Signed-off-by: Mikael Hammarin <mhammarin@ecit.com>
mikaelh
force-pushed
the
feat/sidecars
branch
from
db8290c to
fbb8296
Compare
Contributor
Author
|
ping @tvories |
mikaelh
force-pushed
the
feat/sidecars
branch
from
fbb8296 to
72b97c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikael Hammarin mhammarin@ecit.com
Pull Request
Description of the change
Support to add extra sidecars. A common pattern is to use sidecars to handle local log files so they are handled by cluster-level logging. For Nextcloud, this means handling of nextcloud.log and audit.log files.
Benefits
In GKE and similar managed kubernetes it would be possible to output nextcloud.log and audit.log so it is handled with Google Logging and Monitoring.
Possible drawbacks
NA
Applicable issues
NA
Additional information
NA
Checklist
Chart.yamlaccording to semver.