feat: NC34 support#192
Merged
oleksandr-nc merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
oleksandr-nc
force-pushed
the
nc34-support
branch
2 times, most recently
from
3e5394a to
74d8253
Compare
The NC34 max-version bump was already on main but never released. This bumps the version, adds the changelog entry, and bumps league/commonmark to 2.8.2 to clear the roave/security-advisories conflict that was breaking the static-psalm-analysis CI jobs. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
nc34-support
branch
from
74d8253 to
889efc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the tests were changed:
After a successful TOTP login during OAuth authorize, GitHub now sometimes serves a
Verify your two-factor authentication (2FA) settingscheckup interstitial with a/settings/two_factor_checkup/delay("remind me later") form.