fix: remove url encoding from calendar names

[lukasdotcom]

@MarcelRobitaille

Resolves: #275

[marcelklehr]

🎉 🚀

[MarcelRobitaille]

@lukasdotcom Thanks for the fix.

With this applied, I'm seeing this:

Error index DbalException An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'principals/users/marcel-Test+%28Google+Calendar+import%29' for key 'calendars_index'

Maybe we need some kind of migration

Manually deleted the corresponding rows from oc_calendars fixed it. Can confirm it now looks correct in the UI.

I'm also still able to delete the calendar, which I understand to be the original motivation of #166. The calendar still exists in the database, but I think that's also the behaviour for manually created calendars in the UI. BTW do you know why it does this?

[lukasdotcom]

@lukasdotcom Thanks for the fix.

With this applied, I'm seeing this:

Error index DbalException An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'principals/users/marcel-Test+%28Google+Calendar+import%29' for key 'calendars_index'

Maybe we need some kind of migration

Manually deleted the corresponding rows from oc_calendars fixed it. Can confirm it now looks correct in the UI.

Hi @MarcelRobitaille

Thanks for reporting the problem. When creating the calendar I checked the calendar name instead of uri before creating it. This will be fixed in #280. Thanks for mentioning that.

I'm also still able to delete the calendar, which I understand to be the original motivation of #166. The calendar still exists in the database, but I think that's also the behaviour for manually created calendars in the UI. BTW do you know why it does this?

The reason for the original change was due to the / character. When that character existed in the calendar it would cause issues with deleting it. Luckily there is a display name that also exists that does not have that restriction. You'll notice this pr still encodes the calendar uri which is why the original commit couldn't just be reverted.

[MarcelRobitaille]

You'll notice this pr still encodes the calendar uri which is why the original commit couldn't just be reverted.

Yeah I see that