Skip to content

Conversation

@sp00ktober
Copy link

Implements #2615 replaces #3102

This adds an option to the Auto Upload settings to only sync those assets marked as favorites through the Apple Photos App.

I did some testing in the simulator and with my own Nextcloud server. I am open for improvements of this PR, especially regarding localization. Not sure if i did this the right way or not.

This is just a super handy feature for myself and i was missing it in the app, so i added it.

Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
…branch)

Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
@sp00ktober sp00ktober changed the title Sync favorites only add option to sync favorites only Oct 11, 2024
@marinofaggiana
Copy link
Member

Hi @sp00ktober very thanks !!
when I have a moment of time I watch it

(please resolve the conflict ... in de ?)

Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
@sp00ktober
Copy link
Author

Hey @marinofaggiana thanks for having a look, would be very cool to see this in the app at some point :)

I updated to current develop state and fixed the conflict.

Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
@sp00ktober
Copy link
Author

sp00ktober commented Oct 16, 2024

@marinofaggiana i updated to latest dev branch and fixed the merge conflict, however i am not longer able to build the app due to other changes (mainly NCLivePhoto and the setLivephoto() function)

Signed-off-by: sp00ktober <ezra.knobloch@protonmail.com>
@sp00ktober
Copy link
Author

sp00ktober commented Oct 25, 2024

Fixed merge conflicts. Is there anything more needed from my side on this one or any way i can help to let this progress?
I was able to build and test the app in the simulator again and it was working as expected.

@marinofaggiana
Copy link
Member

Thanks @sp00ktober will be some test !

@marinofaggiana marinofaggiana merged commit 0f626fa into nextcloud:develop Oct 25, 2024
1 check passed
@marinofaggiana marinofaggiana added this to the 6.0.1 milestone Oct 25, 2024
@marinofaggiana
Copy link
Member

there are some things to be done but in the meantime thanks

@sp00ktober
Copy link
Author

thanks too for merging, this feature could save me a lot of manual work :)

Is this now part of version 6.0.1 or 6.1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants