chore: update Psalm to v6 - #11224
Draft
ChristophWurst wants to merge 13 commits into
Draft
Conversation
This was referenced Jun 4, 2025
kesselb
force-pushed
the
test/psalm-6
branch
from
February 13, 2026 13:47
18ffbf6 to
46e2356
Compare
Merged
This was referenced Feb 13, 2026
This was referenced Feb 27, 2026
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
test/psalm-6
branch
from
March 16, 2026 08:34
b518b26 to
a734607
Compare
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
This was referenced Mar 16, 2026
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com> # Conflicts: # composer.json # composer.lock
- InteractionListener: guard foreach against null getRecipients() - Version1130Date20220412111833: cast tempnam() result to string - TransformURLScheme: suppress NullArgument for intentional null URI params - InternalAddressController: handle nullable return from add() - OptionalIndicesListener: fix @template-implements to use AddMissingIndicesEvent - psalm-baseline.xml: remove 2 stale UnusedBaselineEntry items AI-assisted: OpenCode (claude-sonnet-4.6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
# Conflicts: # composer.lock
- Bump nextcloud/rector to ^0.5.0 with new migration rules - Migrate IConfig app-value calls to IAppConfig (getValueString/setValueString) in AntiSpamService, AiIntegrationsService, ClassificationSettingsService, and ContextChatSettingsService; remove now-unused IConfig injection - Update corresponding unit tests to mock IAppConfig instead of IConfig - Finalize standalone test classes (final class) - Replace createMock with createStub where no expectations are needed - Add (string) casts in assertStringContainsString calls to satisfy type checker - Convert single-expression closures to arrow functions AI-assisted: OpenCode (claude-sonnet-4.6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
…ppConfig" This reverts commit 10c3296.
…lity - Fix @return static -> @return self in JsonResponse success/fail/error - Fix psalm-suppress comment in TransformURLScheme for Psalm 6 syntax - Add @psalm-suppress to MessageApiController get/getAttachment - Replace stale AttachmentService baseline entries with correct snippets - Add missing baseline entries for all remaining Psalm 6 type errors AI-assisted: OpenCode (claude-sonnet-4.6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
# Conflicts: # lib/Controller/AvatarsController.php # lib/Controller/InternalAddressController.php # tests/psalm-baseline.xml
2 tasks
1 task
pull Bot
pushed a commit
to dwongdev/mail
that referenced
this pull request
Jul 22, 2026
Psalm 6 enables stricter checks that surface a few pre-existing type issues in code that Psalm 5 accepted. These are behaviour-preserving and can land on main ahead of the Psalm 6 upgrade (nextcloud#11224): - strictBinaryOperands: add explicit (float) casts where int and float operands are mixed (MessageMapper, PerformanceLoggerTask) and (string) casts when concatenating ints (JmapClientFactory) - MissingOverrideAttribute: add #[\Override] to jsonSerialize() in Delegation and sendRequest() in JmapClientAdapter Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
1 task
pull Bot
pushed a commit
to dwongdev/mail
that referenced
this pull request
Aug 22, 2026
Extracts behaviour-preserving type fixes from the Psalm 6 bump (nextcloud#11224) so the eventual version bump stays small: align JsonResponse factory return docblocks with their self return type, null-guard the recipient iteration in InteractionListener, correct the OptionalIndicesListener event template, and cast the tempnam() result in the 1130 migration. Pure Psalm suppressions and the version/baseline changes stay with the bump PR. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.