Missing cache invalidation for `\OCA\Mail\Service\AccountService::findByUserId`

[ChristophWurst]

Steps to reproduce

In a background job

1. Call \OCA\Mail\Service\AccountService::findByUserId
2. Modify the account
3. Call \OCA\Mail\Service\AccountService::findByUserId again

Expected behavior

I see the change.

Actual behavior

I don't see the change.

Mail app version

3.5.0

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response

[st3iny]

Maybe we can remove the cache completely. Most usages seem to be "top-down" e.g. from a controller or listener.

Method
    findByUserId
Usages in All Places  (12 usages found)
    Method call  (10 usages found)
        nextcloud  (10 usages found)
            dev_apps/mail/lib/Command  (1 usage found)
                ExportAccount.php  (1 usage found)
                    ExportAccount  (1 usage found)
                        execute  (1 usage found)
                            56 $accounts = $this->accountService->findByUserId($userId);
            dev_apps/mail/lib/Controller  (3 usages found)
                AccountsController.php  (1 usage found)
                    AccountsController  (1 usage found)
                        index  (1 usage found)
                            109 $mailAccounts = $this->accountService->findByUserId($this->currentUserId);
                PageController.php  (1 usage found)
                    PageController  (1 usage found)
                        index  (1 usage found)
                            154 $mailAccounts = $this->accountService->findByUserId($this->currentUserId);
                TagsController.php  (1 usage found)
                    TagsController  (1 usage found)
                        delete  (1 usage found)
                            99 $accounts = $this->accountService->findByUserId($this->currentUserId);
            dev_apps/mail/lib/Dashboard  (2 usages found)
                MailWidget.php  (1 usage found)
                    MailWidget  (1 usage found)
                        load  (1 usage found)
                            110 $this->accountService->findByUserId($this->userId)
                MailWidgetV2.php  (1 usage found)
                    MailWidgetV2  (1 usage found)
                        getWidgetButtons  (1 usage found)
                            64 $accounts = $this->accountService->findByUserId($this->userId);
            dev_apps/mail/lib/Listener  (2 usages found)
                OutOfOfficeListener.php  (1 usage found)
                    OutOfOfficeListener  (1 usage found)
                        handle  (1 usage found)
                            77 $accounts = $this->accountService->findByUserId($event->getData()->getUser()->getUID());
                UserDeletedListener.php  (1 usage found)
                    UserDeletedListener  (1 usage found)
                        handle  (1 usage found)
                            58 foreach ($this->accountService->findByUserId($user->getUID()) as $account) {