Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Feb 26, 2025

Fix #10747

Things I tested

  1. Compose a new message and send it.
  2. Edit a message in the outbox and send it again.
  3. Toggle the editor mode (plain vs. rich text).
  4. Reply, forward, edit as new.

@SebastianKrupinski
Copy link
Contributor

Question, since you are reworking this, now that we have the htmlBody and plainBody, can we get ride of the editorBody?

@st3iny
Copy link
Member Author

st3iny commented Feb 26, 2025

Question, since you are reworking this, now that we have the htmlBody and plainBody, can we get ride of the editorBody?

Yes, we should be able to get rid. However, I'd move this to another PR.

@ChristophWurst
Copy link
Member

/backport to stable4.3

@ChristophWurst
Copy link
Member

/backport to stable5.0

@st3iny
Copy link
Member Author

st3iny commented Apr 4, 2025

One thing to note: I didn't check if automated message are not editable. Sebastian told me that they can only be detected by their missing editorBody field. However, my logic always relies on htmlBody and plainBody.

@SebastianKrupinski
Copy link
Contributor

Tested. All function in description seem to work correctly

@ChristophWurst
Copy link
Member

4.2 backport stopped

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/composer/body-handling branch from 4da1383 to 58c48ad Compare April 23, 2025 11:00
@st3iny st3iny enabled auto-merge April 23, 2025 11:00
@st3iny st3iny merged commit 32b1dff into main Apr 23, 2025
35 checks passed
@st3iny st3iny deleted the fix/composer/body-handling branch April 23, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't edit email in outbox

4 participants