refactor(ui): make the directives Vue 3 compatible#12596
Merged
ChristophWurst merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
GretaD
approved these changes
Mar 20, 2026
GretaD
reviewed
Mar 20, 2026
src/directives/infinite-scroll.js
Outdated
| } | ||
|
|
||
| const doBind = function() { | ||
| if (this.binded) return |
Contributor
There was a problem hiding this comment.
there are couple of if conditions that dont have the {}
Contributor
There was a problem hiding this comment.
approved so it doesnt get blocked after fixing these
AI-assisted: Claude Code + Opus 4.6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
refactor/ui/directivies-vue2-vue3
branch
from
a085a1e to
9edfe49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nextcloud/groupware#64
Drag-and-drop and infinite scroll still works and this way it's compatible with Vue 2.7 and Vue 3.
AI-assisted: Claude Code + Opus 4.6