fix(ui): use v-model for assistance setting switches#12975
Merged
ChristophWurst merged 1 commit intoMay 26, 2026
Conversation
:checked is not a prop on NcFormBoxSwitch (it expects modelValue), so both the follow-up reminders and context chat switches always appeared off and unresponsive. Switch to v-model which wires the existing computed setters correctly. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Member
Author
|
/backport to stable5.8 |
kesselb
approved these changes
May 26, 2026
ChristophWurst
deleted the
worktree-fix+ui-assistance-context-chat-switches
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:checked is not a prop on NcFormBoxSwitch (it expects modelValue), so both the follow-up reminders and context chat switches always appeared off and unresponsive. Switch to v-model which wires the existing computed setters correctly.
Issue started at 5448209 with defunct :checked attribute and fully broke with d43846f.
Assisted-by: Claude:claude-sonnet-4-6