[codex] fix SMTP sender validation for digit-leading domains#12993
Open
Phillipxh wants to merge 1 commit into
Open
[codex] fix SMTP sender validation for digit-leading domains#12993Phillipxh wants to merge 1 commit into
Phillipxh wants to merge 1 commit into
Conversation
Signed-off-by: Phillipxh <150742483+Phillipxh@users.noreply.github.com>
5fa2f38 to
e040701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LenientSmtphordeTransportwrapperFromheader validation for sender addresses so domains like180grad-kiel.deare acceptedWhy
Horde_Mail_Transport::prepareHeaders()usesHorde_Mail_Rfc822withvalidate => truefor theFromheader. That rejects valid domains whose labels start with digits, which breaks message sending for addresses likeuser@180grad-kiel.deeven though RFC 1123 permits them.This keeps the workaround local to the SMTP transport used by Mail instead of patching vendor code in place.
Validation
From: Test User <user@180grad-kiel.de>git diff --checkphpis not installedCloses #12992