Skip to content

chore: harden the condition when summaries can not be generated #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GretaD wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

chore: harden the condition when summaries can not be generated #13018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/EventModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,11 @@ export default {
try {
this.generatingData = true

const { summary, description } = await generateEventData(this.envelope.databaseId)
const result = await generateEventData(this.envelope.databaseId)
if (!result) {
return
}
const { summary, description } = result
this.eventTitle = summary
this.description = description
} finally {
Expand Down
6 changes: 5 additions & 1 deletion src/components/ThreadEnvelope.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,11 @@ export default {

// Fetch smart replies
if (this.enabledFreePrompt && this.message && !['trash', 'junk'].includes(this.mailbox.specialRole) && !this.showFollowUpHeader) {
this.smartReplies = await smartReply(this.envelope.databaseId)
try {
this.smartReplies = await smartReply(this.envelope.databaseId)
} catch (error) {
logger.error('Could not fetch smart replies', { error })
}
}
},

Expand Down
Loading