Improve animation on EnvelopeList when you delete an email#2130
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
Some sort of animation is needed so that the list items below don’t just jump up when the mail is faded out. And a very quick collapse would be best as that’s the most seamless transition between the 2 states. :) |
is this better or maybe 0.1s slower? |
|
The speed is good, but it still has the issue that it animates down to like 10px and the last part vanishes quickly. As described with the video in issue #1761 :) |
|
Looking good! :) I think @ChristophWurst will also ask to squash your commits into one though, so better do that directly |
I guess you still needs to animate the padding? |
6c8ba1e to
9bc91e9
Compare
I did not test, I assumed your comment was still occurring as I did not see anything related to the padding in the commits :) |
All this UI stuff, a bunch of magic! 🔮 |
Signed-off-by: Greta Doci <gretadoci@gmail.com> Change the animation Signed-off-by: Greta Doci <gretadoci@gmail.com> fix transition Signed-off-by: Greta Doci <gretadoci@gmail.com>
9bc91e9 to
81d8d18
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Looking greta, let’s get this in! 👍
|
Congrats on the commit sha 81d8d18. It almost rimes. |
|
Oh it is actually a palindrome! |
i see what you did there :D |

cc @jancborchardt @ChristophWurst I also removed the transform: scaleY(0), to remove that collapse effect, what do you think?