Skip to content

Improve animation on EnvelopeList when you delete an email#2130

Merged
jancborchardt merged 1 commit into
masterfrom
feature/2110/improve_animation_on_maillist
Oct 23, 2019
Merged

Improve animation on EnvelopeList when you delete an email#2130
jancborchardt merged 1 commit into
masterfrom
feature/2110/improve_animation_on_maillist

Conversation

@GretaD
Copy link
Copy Markdown
Contributor

@GretaD GretaD commented Oct 18, 2019

delete animation: quicker, height left at the end, issue #1761 and here #2110

cc @jancborchardt @ChristophWurst I also removed the transform: scaleY(0), to remove that collapse effect, what do you think?

@welcome
Copy link
Copy Markdown

welcome Bot commented Oct 18, 2019

Thanks for opening your first pull request in this repository! ✌️

@jancborchardt
Copy link
Copy Markdown
Member

I also removed the transform: scaleY(0), to remove that collapse effect, what do you think?

Some sort of animation is needed so that the list items below don’t just jump up when the mail is faded out. And a very quick collapse would be best as that’s the most seamless transition between the 2 states. :)

@GretaD
Copy link
Copy Markdown
Contributor Author

GretaD commented Oct 21, 2019

And a very quick collapse would be best as that’s the most seamless transition between the 2 states. :)

is this better or maybe 0.1s slower?

@jancborchardt
Copy link
Copy Markdown
Member

The speed is good, but it still has the issue that it animates down to like 10px and the last part vanishes quickly. As described with the video in issue #1761 :)

@jancborchardt
Copy link
Copy Markdown
Member

Looking good! :) I think @ChristophWurst will also ask to squash your commits into one though, so better do that directly

Comment thread src/components/EnvelopeList.vue Outdated
@skjnldsv
Copy link
Copy Markdown
Member

The speed is good, but it still has the issue that it animates down to like 10px and the last part vanishes quickly

I guess you still needs to animate the padding?

@GretaD GretaD force-pushed the feature/2110/improve_animation_on_maillist branch from 6c8ba1e to 9bc91e9 Compare October 23, 2019 09:09
@jancborchardt
Copy link
Copy Markdown
Member

Tested again and it seems good to me now, only thing that’s left @GretaD squash into one commit. :) @skjnldsv the padding issue does not occur for me anymore, did you clear the cache?

@skjnldsv
Copy link
Copy Markdown
Member

did you clear the cache?

I did not test, I assumed your comment was still occurring as I did not see anything related to the padding in the commits :)
I'm guessing the speed is faking the instant toggle of the padding collapse ;)

@jancborchardt
Copy link
Copy Markdown
Member

I'm guessing the speed is faking the instant toggle of the padding collapse ;)

All this UI stuff, a bunch of magic! 🔮

Signed-off-by: Greta Doci <gretadoci@gmail.com>

Change the animation

Signed-off-by: Greta Doci <gretadoci@gmail.com>

fix transition

Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD force-pushed the feature/2110/improve_animation_on_maillist branch from 9bc91e9 to 81d8d18 Compare October 23, 2019 13:25
Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking greta, let’s get this in! 👍

@jancborchardt jancborchardt merged commit a98bdc9 into master Oct 23, 2019
@jancborchardt jancborchardt deleted the feature/2110/improve_animation_on_maillist branch October 23, 2019 19:15
@ChristophWurst
Copy link
Copy Markdown
Member

Congrats on the commit sha 81d8d18. It almost rimes.

@ChristophWurst
Copy link
Copy Markdown
Member

Oh it is actually a palindrome!

@jancborchardt
Copy link
Copy Markdown
Member

Where were you when it happened?

81d8d18

@GretaD
Copy link
Copy Markdown
Contributor Author

GretaD commented Oct 24, 2019

Looking greta, let’s get this in! +1

i see what you did there :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants