Move favorite toggle to menu, otherwise not distinguishable

[jancborchardt]

Fix #1032

Before, basically every mail looked like it was favorited. Now we only show a star for mails which really are favorited. And the favorite toggle is moved to the menu.

This aligns it with how we do it in Files as well. :)

Before & after:
| | |

Menu:

[ChristophWurst]

Before, basically every mail looked like it was favorited.

Did it? There is a yellow star for starred items and a grey one for the rest.

IMO this is a primary action. I already kind of dislike that the delete button is so hidden. This makes fast mail triaging harder.

[StCyr]

Before, basically every mail looked like it was favorited.

Did it? There is a yellow star for starred items and a grey one for the rest.

I also never got confused with this behaviour. And, indeed, I like being able to favorite a mail with a single click on the avatar 'star.

But I'm not against adding this action to the Actions menu also.

IMO this is a primary action. I already kind of dislike that the delete button is so hidden. This makes fast mail triaging harder.

That, on the other hand, never frustated me :-)

And, I think that we should implement actions on multiple selection if we want to support faster mail triaging (see #2273)

[StCyr]

ouch! 'just implemented the PR... .I don't like it: Envelopes now looks naked without their tiny grey star :-(

[jancborchardt]

For fast mail triaging, there are the shortcuts, no? If we make the actions visible so presently it will be very crowded.

Before, basically every mail looked like it was favorited.

Did it? There is a yellow star for starred items and a grey one for the rest.

Yes it does. :) Every mail has a star. And even if you do have one or 2 mails favorited, you can’t go by the additional present element, but by the color of an element.

[ChristophWurst]

For fast mail triaging, there are the shortcuts, no?

Usually I do not have a keyboard attached to my phone when I read my mail :)

[StCyr]

Shortcuts aren’t documented IINM. I never use them (and don’t expect users to discover them themselves) EDIT: I’ve just seen that they are documented. Anyway, I didn’t know that until now and that’s why I was not using them. I expect lambda users to have the same experience as I had.

…

Le 25 nov. 2019 à 17:21, Jan-Christoph Borchardt ***@***.***> a écrit :  For fast mail triaging, there are the shortcuts, no? If we make the actions visible so presently it will be very crowded. Before, basically every mail looked like it was favorited. Did it? There is a yellow star for starred items and a grey one for the rest. Yes it does. :) Every mail has a star. And even if you do have one or 2 mails favorited, you can’t go by the additional present element, but by the color of an element. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

[jancborchardt]

Usually I do not have a keyboard attached to my phone when I read my mail :)

I see you want to implement swipe shortcuts? ;) Swipe right to favorite, swipe left to archive/delete in that case.

Seriously though, I would then replace the "unstarred" state icon with an outline icon instead of filled grey, so it’s really distinguishable from the starred state. Makes sense?

EDIT: I’ve just seen that they are documented. Anyway, I didn’t know that until now and that’s why I was not using them.

Yup, we could do a better job showing them in the interface. :) E.g. if you delete 3 mails after another, or star 3 mails in succession etc, it could show a tooltip or so with the shortcut?

[ChristophWurst]

E.g. if you delete 3 mails after another, or star 3 mails in succession etc, it could show a tooltip or so with the shortcut?

Can't help myself but think about

[jancborchardt]

@ChristophWurst yes I know it sounds ridiculous. ;) But when done right, learnable UI is pretty nice. :)