Handle dovecot sieve folder when subdir of INBOX#728
Merged
Conversation
Pull request nextcloud#520 introduced special handling of dovecot's 'dovecot.sieve' folder, so that it isn't queried for a sync token. A common configuration of dovecot is to put all folders as subfolders of INBOX. This pull request adds support for cases when the sieve folder is a subfolder of INBOX. Signed-off-by: Johan Sandelin <johan.sandelin@gmail.com>
Member
Author
|
That looks like the proper solution, yes, if the solution involves removing the INBOX prefix from all subfolders. However the fix in #652 (comment) does not solve the problem for me. Unfortunately I'm not comfortable enough with docker to create an image for you to test. |
Member
|
I'm fine with accepting this temporary fix if
|
Code style has been fixed, and a comment that this workaround should be removed once nextcloud#386 has been closed has been added. Signed-off-by: Johan Sandelin <johan.sandelin@gmail.com>
Closed
Member
|
Thanks a lot! |
Member
Member
|
@j0s FYI your email address used for the commits here is not associated with your account. You might want to add it to your account, then GitHub will correctly show you as author 😉 |
Member
Congrats on your first contribution btw 🙌 Looking forward to more contributions ✨ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #520 introduced special handling of dovecot's
'dovecot.sieve' folder, so that it isn't queried for a sync
token. A common configuration of dovecot is to put all folders as
subfolders of INBOX. This pull request adds support for
cases when the sieve folder is a subfolder of INBOX.