Skip to content

Fix: downgrade webdav to fix Filepicker#9587

Merged
st3iny merged 1 commit intomainfrom
fix/filepicker-webdav-revert
Apr 22, 2024
Merged

Fix: downgrade webdav to fix Filepicker#9587
st3iny merged 1 commit intomainfrom
fix/filepicker-webdav-revert

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented Apr 22, 2024

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 requested review from GretaD and st3iny April 22, 2024 12:58
@hamza221 hamza221 self-assigned this Apr 22, 2024
@hamza221 hamza221 marked this pull request as ready for review April 22, 2024 12:58
Copy link
Copy Markdown
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks here:

mail/src/dav/client.js

Lines 33 to 34 in d24f984

const patcher = webdav.getPatcher()
patcher.patch('request', axios)

Webdav switched to the fetch API internally and we still force it to use axios. Hence it breaks somewhere in the library as response.text() is not a function in axios.

@st3iny
Copy link
Copy Markdown
Member

st3iny commented Apr 22, 2024

/backport to stable3.6

@st3iny st3iny added this to the v3.7.0 milestone Apr 22, 2024
@st3iny st3iny merged commit 7f80572 into main Apr 22, 2024
@st3iny st3iny deleted the fix/filepicker-webdav-revert branch April 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants