Conversation
Contributor
|
It looks nice but when we change the design, we should consult it with the design team as well |
jancborchardt
requested changes
Jul 23, 2024
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Awesome, looks good to me! Only 1 thing, the capitalization needs to be "Sentence case" everywhere as per design guidelines. E.g. "Sieve host" instead of "Sieve Host".
st3iny
reviewed
Jul 23, 2024
GretaD
approved these changes
Jul 23, 2024
GVodyanov
force-pushed
the
style/make-sieve-security-settings-pretty
branch
from
925b891 to
2bf1854
Compare
…ve styling Signed-off-by: Grigory V <scratchx@gmx.com>
GVodyanov
force-pushed
the
style/make-sieve-security-settings-pretty
branch
from
324e04b to
3297215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9894
Chromium:
Firefox: