Skip to content

Conversation

@provokateurin
Copy link
Member

I'm not sure it will work right away, but let's see 🚀

@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch 3 times, most recently from 94fabbf to c882b3a Compare December 12, 2024 10:21
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (0390e23) to head (b1a31fb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/nextcloud/lib/src/models/version_check.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   28.61%   28.61%           
=======================================
  Files         374      374           
  Lines      144735   144735           
=======================================
  Hits        41417    41417           
  Misses     103318   103318           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 62.44% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0390e23
neon_framework 59.23% <ø> (ø)
neon_http_client 92.38% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 0390e23
neon_rich_text 100.00% <ø> (ø)
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from 0390e23
nextcloud 24.22% <0.00%> (ø)
notifications_app 97.43% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.84% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/nextcloud/lib/src/models/version_check.dart 64.70% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial feedback

Comment on lines 18 to +19
neon_lints:
git:
url: https://github.com/nextcloud/neon
path: packages/neon_lints
path: ../../../neon_lints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have it as a dev_dependency of the workspace package and just use a global analysis_options.yaml.

Every package may still alter the rule set but this would make our lints the default (also for newly added packages).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about this, but yes it makes sense. How are we going to handle custom_lint though? We need to disable some of the rules for specific packages?
OTOH this brings up the point of removing custom_lint entirely, given that it mostly causes headaches and hasn't caught so many problems so far.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this into a separate issue as it's not really a blocker and we really need this PR to make everything simpler: #2925

@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch from c882b3a to 0c0d0dd Compare December 14, 2024 15:30
@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch from 0c0d0dd to 4202ca1 Compare December 14, 2024 16:01
@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch from 4202ca1 to 26d8793 Compare December 23, 2024 08:48
@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch 2 times, most recently from 9d990ba to cbd2eb0 Compare January 25, 2025 11:26
@provokateurin
Copy link
Member Author

For the tests with downgraded dependencies we probably need test: ^1.25.12: https://github.com/dart-lang/test/blob/master/pkgs/test/CHANGELOG.md#12512
Unfortunately we are currently stuck: #2680

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the build/migrate_pub_workspace branch from 8915917 to b1a31fb Compare April 25, 2025 06:37
@provokateurin provokateurin marked this pull request as ready for review April 25, 2025 06:37
@provokateurin provokateurin merged commit 292ff0b into main Apr 25, 2025
10 of 11 checks passed
@provokateurin provokateurin deleted the build/migrate_pub_workspace branch April 25, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants