-
Notifications
You must be signed in to change notification settings - Fork 38
build!: Migrate to pub workspace #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94fabbf to
c882b3a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 28.61% 28.61%
=======================================
Files 374 374
Lines 144735 144735
=======================================
Hits 41417 41417
Misses 103318 103318
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Leptopoda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial feedback
| neon_lints: | ||
| git: | ||
| url: https://github.com/nextcloud/neon | ||
| path: packages/neon_lints | ||
| path: ../../../neon_lints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have it as a dev_dependency of the workspace package and just use a global analysis_options.yaml.
Every package may still alter the rule set but this would make our lints the default (also for newly added packages).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about this, but yes it makes sense. How are we going to handle custom_lint though? We need to disable some of the rules for specific packages?
OTOH this brings up the point of removing custom_lint entirely, given that it mostly causes headaches and hasn't caught so many problems so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this into a separate issue as it's not really a blocker and we really need this PR to make everything simpler: #2925
c882b3a to
0c0d0dd
Compare
0c0d0dd to
4202ca1
Compare
4202ca1 to
26d8793
Compare
9d990ba to
cbd2eb0
Compare
|
For the tests with downgraded dependencies we probably need |
cbd2eb0 to
8915917
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
8915917 to
b1a31fb
Compare
I'm not sure it will work right away, but let's see 🚀