feat: add notifications when sharing articles with users by eureka928 · Pull Request #3542 · nextcloud/news

eureka928 · 2026-02-04T22:23:37Z

Resolves: Problematic behavior of the "Share" button #2102

Summary

This PR adds in-app notifications when a user shares an article with another user, addressing the second issue reported in #2102.

Register a Notifier service in the Nextcloud notification framework to prepare and display share notifications
Send a notification to the recipient in ShareService::shareItemWithUser() with the sharer's name and article title
Use UnknownNotificationException per the Nextcloud notification API docs
Use Application::NAME constant instead of hardcoded 'news' string
Notification includes rich subject with user and article parameters, a link to the News app, and the app icon
Notification failures are caught and logged so they don't break the share operation

New files

lib/Notification/Notifier.php - INotifier implementation for the News app
tests/Unit/Notification/NotifierTest.php - Unit tests for the Notifier class

Modified files

lib/AppInfo/Application.php - Registers the Notifier service
lib/Service/ShareService.php - Sends notification after sharing
tests/Unit/Service/ShareServiceTest.php - Updated with notification expectations

Checklist

Code is properly formatted
Sign-off message is added to all commits
Changelog entry added for all important changes.

eureka928 · 2026-02-06T10:20:15Z

Hi @Grotax how are you?
Would you review this PR?
Thank you

Grotax · 2026-02-06T10:21:22Z

No

eureka928 · 2026-02-06T10:23:56Z

No

What's wrong? I'd like to contribute so I put the PR for feed-io as well as here...

Grotax · 2026-02-06T13:45:03Z

I review when I have time and energy and your pinging is not helpful.

Copilot

Pull request overview

This PR adds Nextcloud in-app notifications for the News app when an article is shared with another user, by registering a notification Notifier and sending a notification from ShareService::shareItemWithUser().

Changes:

Register a News Notifier with Nextcloud’s notification framework.
Send a “shared article” notification after successfully sharing an item.
Add unit tests for the Notifier and update ShareService unit tests to assert notification behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`lib/AppInfo/Application.php`	Registers the News notification notifier service.
`lib/Service/ShareService.php`	Injects `OCP\Notification\IManager` and sends a notification after sharing.
`lib/Notification/Notifier.php`	Implements notification preparation (parsed/rich subject, link, icon).
`tests/Unit/Service/ShareServiceTest.php`	Adds notification manager + notification expectations for sharing tests.
`tests/Unit/Notification/NotifierTest.php`	New unit tests covering notifier behavior and edge cases.

lib/Service/ShareService.php

lib/Notification/Notifier.php

tests/Unit/Notification/NotifierTest.php

Users now receive a notification when someone shares an article with them. The notification includes: - Sharer's display name - Article title (truncated if > 100 chars) - Clickable link to open the News app - News app icon Implementation details: - Added Notifier class implementing INotifier interface - Registered notifier in Application.php - ShareService sends notification after successful share - Notification failures are logged but don't break the share flow Fixes nextcloud#2102 (notification part - focus fix was already implemented) Signed-off-by: eureka928 <meobius123@gmail.com> Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

… add Notifier tests Replace hardcoded 'news' string with Application::NAME in ShareService and use the proper UnknownNotificationException from the Nextcloud notification API instead of \InvalidArgumentException in the Notifier. Add unit tests for the Notifier class. Signed-off-by: eureka928 <meobius123@gmail.com> Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

SMillerDev · 2026-02-08T09:30:15Z

lib/Notification/Notifier.php

+            throw new UnknownNotificationException();
+        }
+
+        $l = $this->l10nFactory->get(Application::NAME, $languageCode);


Please give variables a descriptive name. L is not enough to know it's an l10n factory

SMillerDev · 2026-02-08T09:30:37Z

lib/Notification/Notifier.php

+
+        $l = $this->l10nFactory->get(Application::NAME, $languageCode);
+
+        switch ($notification->getSubject()) {


This looks nicer as a match

SMillerDev · 2026-02-08T09:31:14Z

lib/Notification/Notifier.php

+    private function prepareSharedArticle(INotification $notification, \OCP\IL10N $l): INotification
+    {
+        $params = $notification->getSubjectParameters();
+        $sharerUserId = $params['sharedBy'] ?? '';


When would this be null?

Changed - Notifications for shared articles - recipients now receive a notification when someone shares an article with them (#3542) Fixed - global starred count not updated when deleting a feed with starred items (#3507) - feed fetcher requests may get stuck (#3528) - feed logo download and `fulltext` scraper don't use configured proxy (#3533) - Dependency scoping incompatible with auto-downloaded composer (#3418) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

eureka928 force-pushed the fix/share-notifications-2102 branch from 892bdfa to 61db68c Compare February 4, 2026 22:25

Grotax approved these changes Feb 8, 2026

View reviewed changes

Grotax requested a review from Copilot February 8, 2026 08:46

Copilot started reviewing on behalf of Grotax February 8, 2026 08:47 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Grotax force-pushed the fix/share-notifications-2102 branch from e89c95f to 70027d3 Compare February 8, 2026 09:21

eureka928 and others added 7 commits February 8, 2026 10:24

Use the item the user recieves, not the original

42a840a

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

fallback to Somone if user is not found

b403bc3

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

Maintenance: update devcontainer

2ff75eb

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

Maintenance: update Authors file

dc96e65

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

update changelog

4279e10

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>

Grotax force-pushed the fix/share-notifications-2102 branch from 70027d3 to 4279e10 Compare February 8, 2026 09:24

Grotax merged commit 60958ee into nextcloud:master Feb 8, 2026
27 checks passed

SMillerDev reviewed Feb 8, 2026

View reviewed changes

Grotax mentioned this pull request Feb 8, 2026

Release 28.0.0-beta.3 #3550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add notifications when sharing articles with users#3542

feat: add notifications when sharing articles with users#3542
Grotax merged 7 commits intonextcloud:masterfrom
eureka928:fix/share-notifications-2102

eureka928 commented Feb 4, 2026

Uh oh!

eureka928 commented Feb 6, 2026

Uh oh!

Grotax commented Feb 6, 2026

Uh oh!

eureka928 commented Feb 6, 2026

Uh oh!

Grotax commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SMillerDev Feb 8, 2026

Uh oh!

SMillerDev Feb 8, 2026

Uh oh!

SMillerDev Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		$l = $this->l10nFactory->get(Application::NAME, $languageCode);

		switch ($notification->getSubject()) {

Conversation

eureka928 commented Feb 4, 2026

Summary

New files

Modified files

Checklist

Uh oh!

eureka928 commented Feb 6, 2026

Uh oh!

Grotax commented Feb 6, 2026

Uh oh!

eureka928 commented Feb 6, 2026

Uh oh!

Grotax commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SMillerDev Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

SMillerDev Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

SMillerDev Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants