Skip to content

fix: NcCheckBoxRadioSwitch requires value as string#3733

Merged
Grotax merged 1 commit into
nextcloud:masterfrom
wofferl:fix_feedinfo_checkbox
May 12, 2026
Merged

fix: NcCheckBoxRadioSwitch requires value as string#3733
Grotax merged 1 commit into
nextcloud:masterfrom
wofferl:fix_feedinfo_checkbox

Conversation

@wofferl
Copy link
Copy Markdown
Collaborator

@wofferl wofferl commented May 12, 2026

Summary

This PR fixes a type mismatch for the value prop in NcCheckboxRadioSwitch which should be a string.

stderr | tests/javascript/unit/components/modals/FeedInfoTable.spec.ts > FeedInfoTable.vue > Loading State > should show loading note card when loading is true
[Vue warn]: Invalid prop: type check failed for prop "value". Expected String with value "1", got Number with value 1.
  at <NcCheckboxRadioSwitch modelValue= [] onUpdate:modelValue=fn value=1  ... >
  at <Transition name="modal-in" appear="" >
  at <Transition name="fade" appear="" onAfterEnter=fn<useFocusTrap>  ... >
  at <NcModal size="large" labelId="feed-settings-dialog" closeOnClickOutside=true  ... >
  at <FeedInfoTable ref="VTU_COMPONENT" >
  at <VTUROOT>

Checklist

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl added bug frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change labels May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Grotax Grotax merged commit 24267a6 into nextcloud:master May 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants