Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Is there any way we can just remove the polyfill? |
Member
Author
Apperently not, its also in there for other reasons, the curse of php and php scoping but if you can come up with a better solution go for it :) |
Member
Author
|
@SMillerDev Maybe we should just reverse the PR #3766. So far I can't get it to work and its super annoying. |
Member
Author
|
nvm seems like it works now but yea not a fan of the scoping |
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Jun 4, 2026
Fixed - Fixed News not starting since 28.5.0 due to php class loading issues (#3780) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
|
thank you for fixing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist