Update httpLastModified from the feed response#594
Merged
Conversation
9cce1a8 to
344a0f8
Compare
Contributor
|
Tests are failing. Please fix those |
344a0f8 to
b081448
Compare
1 task
Grotax
approved these changes
Dec 26, 2019
Merged
44240a3 to
8aa5ec8
Compare
LastModified is used (in a feed context to see if a user edited a feed). httpLastModified to store the last-modified response from the source. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
8aa5ec8 to
c6877ad
Compare
Grotax
added a commit
that referenced
this pull request
Dec 27, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #588
LastModified is used (in a feed context to see if a user edited a feed). httpLastModified to store the last-modified response from the source.
Without the patch the
http_last_modifiedvalue is not longer updated hence updates for feeds will always request the whole data.news/lib/Db/NewsMapper.php
Lines 39 to 49 in becce6b
last_modifiedseems to be a field to track changes for a record.http_last_modifiedis the field for the lastmodified timestamp.