Skip to content

Update httpLastModified from the feed response#594

Merged
Grotax merged 1 commit intomasterfrom
fix/588/use-http-last-modified
Dec 27, 2019
Merged

Update httpLastModified from the feed response#594
Grotax merged 1 commit intomasterfrom
fix/588/use-http-last-modified

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 24, 2019

Fix #588

LastModified is used (in a feed context to see if a user edited a feed). httpLastModified to store the last-modified response from the source.

Without the patch the http_last_modified value is not longer updated hence updates for feeds will always request the whole data.

public function update(Entity $entity)
{
$entity->setLastModified($this->time->getMicroTime());
return parent::update($entity);
}
public function insert(Entity $entity)
{
$entity->setLastModified($this->time->getMicroTime());
return parent::insert($entity);
}

last_modified seems to be a field to track changes for a record. http_last_modified is the field for the lastmodified timestamp.

@SMillerDev
Copy link
Contributor

Tests are failing. Please fix those

@Grotax Grotax mentioned this pull request Dec 26, 2019
@kesselb kesselb force-pushed the fix/588/use-http-last-modified branch from 44240a3 to 8aa5ec8 Compare December 26, 2019 14:03
LastModified is used (in a feed context to see if a user edited a feed). httpLastModified to store the last-modified response from the source.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the fix/588/use-http-last-modified branch from 8aa5ec8 to c6877ad Compare December 26, 2019 14:20
@Grotax Grotax merged commit f045bd0 into master Dec 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/588/use-http-last-modified branch December 27, 2019 02:51
Grotax added a commit that referenced this pull request Dec 27, 2019
Changed
- Minimum PHP version is now 7.2
- Reimplement full-text scraping #563
- Update for nextcloud 18 #593 #583
- Update httpLastModified from the feed response #594

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NextCloud-News generates unreasonable amounts of traffic.

3 participants