Skip to content
This repository was archived by the owner on Oct 19, 2022. It is now read-only.

Added Animations on HomePage and Enterprise#171

Merged
jospoortvliet merged 16 commits intomasterfrom
paulo-playground
Oct 13, 2016
Merged

Added Animations on HomePage and Enterprise#171
jospoortvliet merged 16 commits intomasterfrom
paulo-playground

Conversation

@Espina2
Copy link
Copy Markdown
Contributor

@Espina2 Espina2 commented Oct 10, 2016

No description provided.

@Espina2
Copy link
Copy Markdown
Contributor Author

Espina2 commented Oct 10, 2016

@nextcloud/designers @LukasReschke can review and merge?

@Espina2 Espina2 closed this Oct 10, 2016
@Espina2 Espina2 reopened this Oct 10, 2016
@jancborchardt
Copy link
Copy Markdown
Member

@LukasReschke can you deploy it to staging?

Comment thread assets/css/custom.css
padding-right: 30px; }
.Header-Navigation .navbar li a {
color: white; }
.Header-Navigation .navbar li a:after {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking the download button! :/
screen

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added in the last commit ( I shouldn't commit that yet). I trying to figure out why a not :last-child doesn't work for an after pseudo-element.

Copy link
Copy Markdown
Member

@skjnldsv skjnldsv Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works here! :)

Copy link
Copy Markdown
Contributor Author

@Espina2 Espina2 Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are editing directly the .css file, I'm talking about the changing in the .scss file. But if you can make it work just made a commit with the last-child not having an after element. This should work

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Good luck. The rest looks good :)

@LukasReschke
Copy link
Copy Markdown
Member

Resolved the conflict and deployed at https://nextcloud.com/enterprise/?staging=true and https://nextcloud.com/?staging=true

Let me see how to fix the download button…

a{
width: 290px;
height: 60px;
padding-top: 16px
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrongly intended.

height: 100%;
width: 100%;

img {
Copy link
Copy Markdown
Member

@LukasReschke LukasReschke Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well. Might want to look into tabs vs. spaces in your text editing tool :)

@Espina2
Copy link
Copy Markdown
Contributor Author

Espina2 commented Oct 10, 2016

I think you not include the main.js file in the deploy. Can you check @LukasReschke

@Espina2
Copy link
Copy Markdown
Contributor Author

Espina2 commented Oct 12, 2016

@LukasReschke @jospoortvliet We need to deploy the main.js for testing.

@LukasReschke
Copy link
Copy Markdown
Member

@LukasReschke @jospoortvliet We need to deploy the main.js for testing.

It is. But it doesn't seem to be included anywhere or am I missing something? :)

@Espina2
Copy link
Copy Markdown
Contributor Author

Espina2 commented Oct 12, 2016

You have misses something. Maybe some script code in the homepage html. @LukasReschke can you take a look?

@LukasReschke
Copy link
Copy Markdown
Member

You have misses something. Maybe some script code in the homepage html. @LukasReschke can you take a look?

Sure. So "main.js" should be included on every page or just on a specific one?

@Espina2
Copy link
Copy Markdown
Contributor Author

Espina2 commented Oct 12, 2016

Yup, for now the main.js should be in everypage. More later we need to think about require.js.

@jospoortvliet
Copy link
Copy Markdown
Member

2 questions/comments.

  1. can we do this in css, not javascript and
  2. I note that the texts under the three items just under the header on the front page has disappeared.

@jospoortvliet jospoortvliet merged commit 1c45b7d into master Oct 13, 2016
@jospoortvliet jospoortvliet deleted the paulo-playground branch October 13, 2016 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants