Added Animations on HomePage and Enterprise#171
Conversation
|
@nextcloud/designers @LukasReschke can review and merge? |
|
@LukasReschke can you deploy it to staging? |
| padding-right: 30px; } | ||
| .Header-Navigation .navbar li a { | ||
| color: white; } | ||
| .Header-Navigation .navbar li a:after { |
There was a problem hiding this comment.
This is added in the last commit ( I shouldn't commit that yet). I trying to figure out why a not :last-child doesn't work for an after pseudo-element.
There was a problem hiding this comment.
You are editing directly the .css file, I'm talking about the changing in the .scss file. But if you can make it work just made a commit with the last-child not having an after element. This should work
There was a problem hiding this comment.
Okay! Good luck. The rest looks good :)
f47e2e9 to
fdab2c8
Compare
|
Resolved the conflict and deployed at https://nextcloud.com/enterprise/?staging=true and https://nextcloud.com/?staging=true Let me see how to fix the download button… |
| a{ | ||
| width: 290px; | ||
| height: 60px; | ||
| padding-top: 16px |
There was a problem hiding this comment.
This looks wrongly intended.
| height: 100%; | ||
| width: 100%; | ||
|
|
||
| img { |
There was a problem hiding this comment.
As well. Might want to look into tabs vs. spaces in your text editing tool :)
|
I think you not include the main.js file in the deploy. Can you check @LukasReschke |
|
@LukasReschke @jospoortvliet We need to deploy the main.js for testing. |
It is. But it doesn't seem to be included anywhere or am I missing something? :) |
|
You have misses something. Maybe some script code in the homepage html. @LukasReschke can you take a look? |
Sure. So "main.js" should be included on every page or just on a specific one? |
|
Yup, for now the main.js should be in everypage. More later we need to think about require.js. |
|
2 questions/comments.
|

No description provided.