Added support for NSFileProviderRequest in Logging #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for logging NSFileProviderRequest objects in the NextcloudFileProviderKit logging system. The changes enable developers to capture and format NSFileProviderRequest details in log entries, providing better visibility into file provider operations.
- Added a new log detail key case for NSFileProviderRequest objects
- Implemented structured logging format for NSFileProviderRequest with key properties
- Added string representation for NSFileProviderRequest in log output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| FileProviderLogDetailKey.swift | Added new request case to enum for NSFileProviderRequest logging |
| FileProviderLogDetail.swift | Added dictionary encoding support for NSFileProviderRequest objects |
| FileProviderLog.swift | Added string description formatting for NSFileProviderRequest in log output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nilsding
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.