Exclude Lock Files from Synchronization #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the required capability. Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error handling for lock files when server-side locking capabilities are unavailable. Instead of returning a generic synchronization error, the code now uses the more appropriate excludedFromSync error on macOS 13.0+, while maintaining backward compatibility with earlier versions. The change includes improved logging to clarify why lock files are being excluded.
- Returns
NSFileProviderError(.excludedFromSync)on macOS 13.0+ when locking capability is missing - Maintains backward compatibility by using
cannotSynchronizeerror on earlier macOS versions - Adds debug logging to explain why lock files are excluded from synchronization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nilsding
approved these changes
Oct 17, 2025
github-project-automation
bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 💻 Desktop Clients team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the special use case of the sever not supporting locks.