Add custom metrics exporter#1444
Conversation
284b370 to
5cb2c82
Compare
21368c1 to
5be2a79
Compare
fcd96ff to
c9009eb
Compare
|
I have now squashed all intermediate commits so the remaining ones are meaningful. As far as I'm concerned, the PR is now ready to be reviewed/merged (I'll probably move the local prometheus/grafana service feature to its own PR, as that's again a lot of work). |
nachoparker
left a comment
There was a problem hiding this comment.
why are we touching backups and nc-datadir here? how is it affected by metrics?
The new metrics exporter adds backup monitoring. For that to work I need the paths to the backup locations which are stored in a config file at /usr/local/etc/ncp-metrics.cfg. I added a hook to all of the scripts that change backup paths which triggers the regeneration of the config file and a restart of the custom metrics exporter. |
|
understood, LGTM then. Feel free to merge to devel if it has been tested in both VM and docker. I normally use the |
|
Good to know. I didn't notice that script yet :) I already tested it in docker and VM, but I want to change it to use 64bit binaries on 64bit architectures. That makes the install script less complicated (no dependencies on different apt packages on different archs) and thus makes ncp instances more consistent and I think that's preferable on the long run. Also I like the approach you took with the notify_push binaries: to download all binaries and just use the correct one. I'll adjust it to do the same with ncp-metrics-exporter :) |
bb53e99 to
ef3e60b
Compare
Signed-off-by: Tobias K <6317548+theCalcaholic@users.noreply.github.com>
Signed-off-by: Tobias K <6317548+theCalcaholic@users.noreply.github.com>
Signed-off-by: Tobias K <6317548+theCalcaholic@users.noreply.github.com>
d4d7397 to
959f833
Compare
Signed-off-by: Tobias K <6317548+theCalcaholic@users.noreply.github.com>
959f833 to
d21c417
Compare
d21c417 to
1ce2135
Compare
- Upgrade ncp-metrics-exporter to v1.1.0 - Install prometheus-node-exporter-collectors when dist-upgrading from buster Signed-off-by: Tobias K <6317548+theCalcaholic@users.noreply.github.com>
1ce2135 to
d42a0c8
Compare
Include custom Prometheus metrics exporter from https://github.com/theCalcaholic/ncp-metrics-exporter. Currently supports only backup monitoring.
TODO:
[ ] Integrate local prometheus and grafana services as an option (feasibility evaluation pending)Testing
I'm testing the app by installing it into an ncp instance (either via
ncp-update feature/custom-prometheus-exporteror by directly using the curl installer with this branch) and then activating it via ncp-config. After a backup has been created (e.g. via nc-backup), it should appear in https:///metrics/ncp and https:///metrics/system should be populated.TODO: