nc-limits.sh: Do not trigger ERR trap due to failed tests #2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Knöppler <6317548+theCalcaholic@users.noreply.github.com>
Collaborator
|
Thank you for the PR! I'll cherry-pick your commit due to the changed base branch and merge that way. |
Collaborator
|
93364e5 has been cherry-picked into devel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERR traps introduced in commits e05db18 & ee07434 revealed a bug in
update-nc.sh, triggered bybin/ncp-update-nc.d/upgrade-php-bullseye-8.1.shorbin/ncp-update-nc.d/upgrade-php-bookworm-8.3.sh: Whenever either of the two conditional lists fails inupdate-nc.sh, theconfigurefunction will return a non-zero status, triggering the ERR trap inherited from the & executing the rollback fromphp_restore.The fix is to ensure the conditional lists do not return a non-zero status.