Refactored Login

[i2h3]

This resolves #97.

[i2h3]

Work Left To Do

• Improve appearance on iPad. Right now, the views were written for iPhone and might need some adaption here and there to not melt across the whole large screen like cheese.
• Consult designers about user experience feedback since this differs from both Nextcloud Files and Nextcloud Talk apps in the details for technical and organizational reasons.

Considerations

• Horizontal orientation
• Vertical orientation
• iPhone
• iPad
• Light appearance
• Dark appearance

[i2h3]

Demo Screen Recordings

• The accounts shared by other apps like Nextcloud Files are available in a selection sheet.
• That sheet appears automatically on first appearance of the login and with availability of shared accounts.
• The QR code scanner cannot show actual camera view due to being run in Simulator.
• The notes are loaded automatically on login now which did not happen before.
• The settings are updated with account information instead of login form and a previously missing logout button.

iPhone

97-demo-iphone-simulator-github.mp4

iPad

97-demo-ipad-simulator-github.mp4

[jancborchardt]

Very nice! :) Small improvement: Rather than the icon-only buttons on the bottom, it would be nice if they have text. Probably "Add existing account" (is that the proper wording?) and "Log in with QR code".

[i2h3]

Alternative Login Method Design Changes

To have buttons with labels, the layout must be adapted to account for localization problems due to varying text lengths.

iPhone SE (3rd Gen) in Portrait Orientation

iPhone 16 Pro Max in Portrait Orientation

iPad in Landscape Orientation

iPad in Portrait Orientation

[mpivchev]

This looks really nice, can we move it to Files as well 😆

[mpivchev]

Can this be a fullscreen modal? it will then be similar to Files iOS

[mpivchev]

Localization needs to be added

[kra-mo]

Very nice indeed!

I just have two pieces of feedback about wording:

1. "Shared Accounts" and the corresponding description are a bit too much. For one, "Shared Accounts" sounds like a brand name for a feature, especially because of how its capitalized. Our writing style is sentence-case throughout which is usually sometimes followed even in our platform-native apps* The description also seems a bit wordy. How about dropping the description and just having "Accounts from other apps" as the title?
2. The "Log Out" button is outside the "Account" section in Settings, but the version numbers are in there. Could the two basically just be swapped? :)

*We should make sure capitalization is consistent across our iOS apps. I'm personally pro title case as it is what the platform guidelines recommend, but right now it's completely inconsistent. It would be nice to agree on one and coordinate changing all strings to match it.

[i2h3]

1. "Shared Accounts" and the corresponding description are a bit too much. For one, "Shared Accounts" sounds like a brand name for a feature, especially because of how its capitalized. Our writing style is sentence-case throughout which is usually sometimes followed even in our platform-native apps* The description also seems a bit wordy. How about dropping the description and just having "Accounts from other apps" as the title?

What part are you referring to exactly, @kra-mo? I assume you only mean the single sheet title, right? I updated it.

*We should make sure capitalization is consistent across our iOS apps. I'm personally pro title case as it is what the platform guidelines recommend, but right now it's completely inconsistent. It would be nice to agree on one and coordinate changing all strings to match it.

Platform conventions always beat corporate practice in my opinion. Out of experience, one will loose with the latter by reaching inevitable limitations at some point. You should probably discuss this with @jancborchardt who has the opposite opinion.

[i2h3]

Can this be a fullscreen modal? it will then be similar to Files iOS

The files and talk apps are inconsistent already, @mpivchev. Also, the master-detail navigation pattern used in the files app is conflicting with the back and forth inside the web view, creating a two level back- and forth navigation. The sheet provides a conventional experience for the cancellable and modal process in front. It maintains the usual swipe down gesture to dismiss. It also is more consistent with the presentation on larger screens like iPad. I updated the sheet to not have a navigation bar anymore which only occupies screen space without any value.

This also is a design decision to a large extend and if this is a serious concern, then we should rather discuss it in a larger round with the designers.

[kra-mo]

What part are you referring to exactly, @kra-mo? I assume you only mean the single sheet title, right? I updated it.

Thanks, I think this looks great now. I will discuss with Jan then :)

[jancborchardt]

Platform conventions always beat corporate practice in my opinion. Out of experience, one will loose with the latter by reaching inevitable limitations at some point. You should probably discuss this with @jancborchardt who has the opposite opinion.

@i2h3 just discussed with @kra-mo as well, and to be clear: I also think that platform conventions should be the primary thing followed. This is also why we refer the Apple HIG in our design guidelines, and why we say to use SF Symbols (rathr than Material Design icons), and the San Francisco font, etc. :)

[i2h3]

@mpivchev @jancborchardt @kra-mo 4.4.0 build 2 available in TestFlight now: https://testflight.apple.com/join/m7C1rYuN

[i2h3]

@mpivchev @jancborchardt You need to review again and check for your requested changes to be implemented. I still need your approval before I can integrate this.

[jancborchardt]

I don't have access to an iOS device until Friday late eve – but since @kra-mo said that it looks great now, I'd consider it approved from design side. :)

[i2h3]

@jancborchardt What I meant was pressing the button to now approve this pull request because GitHub blocks it otherwise. 😄 As visible in the checks, you requested changes. I could probably dismiss your review but it would be incorrect. You just need to approve on GitHub this time.

[jancborchardt]

@i2h3 here you go, nice work! :)

[i2h3]

Now only @mpivchev needs to review again and approve, hopefully. 🙂

[mpivchev]

LGTM :) Just one question