feat(ui): adapt notes settings to new UI components #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
juliusknorr,
kra-mo,
marcoambrosini,
max-nextcloud and
mejo-
juliusknorr
requested changes
Nov 11, 2025
Member
There was a problem hiding this comment.
@nextcloud/vueis not bumped so the build fails with unknown components.
preferred to create 2 separate PR's
I find it odd that CI still passes with this, so this is something that should also be addressed
Changing the settings does not store them on the server (you can see that no request is send, which was the case before
ShGKme
reviewed
Nov 12, 2025
ShGKme
reviewed
Nov 12, 2025
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/1646-Notes-settings-reorganization
branch
from
d751673 to
f557367
Compare
juliusknorr
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1646
Dependency updates:
nextcloud/vue#1664nextcloud/webpack-vue-configand installvue-loader#1663🖼️ Screenshots