Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 12, 2025

Change imports to specific ones instead of using the single root import as documented in https://github.com/nextcloud-libraries/nextcloud-vue#-usage

This will result in smaller bundle sizes and a faster build time.

To be merged after #1661 to avoid conflicts

There is still some duplication where notes-common is not used in notes-main, to be figured out ...

Bundle comparison with webpack-bundle-analyze

Before After
7,9M 3,5M
Screenshot 2025-11-12 at 08 44 43 Screenshot 2025-11-12 at 08 44 46

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1646-Notes-settings-reorganization branch from d751673 to f557367 Compare November 12, 2025 15:31
Base automatically changed from fix/1646-Notes-settings-reorganization to main November 12, 2025 16:10
…d time

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the perf/bundle-size-imports branch from 4cdf765 to 6031c3d Compare November 13, 2025 09:55
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Likely worth doing on Tables and other apps

@enjeck enjeck merged commit a6fd9cc into main Nov 21, 2025
31 checks passed
@enjeck enjeck deleted the perf/bundle-size-imports branch November 21, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants